refactor: use k8s_service_info lib instead of SDI #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
labels
DnPlas
force-pushed
the
KF-5485-use-k8s-service-info-lib
branch
from
7ad1ed8
to
639c807
Compare
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
DnPlas
force-pushed
the
KF-5485-use-k8s-service-info-lib
branch
from
639c807
to
92184ab
Compare
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
DnPlas
force-pushed
the
KF-5485-use-k8s-service-info-lib
branch
from
92184ab
to
c748fb0
Compare
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
DnPlas
force-pushed
the
KF-5485-use-k8s-service-info-lib
branch
from
c748fb0
to
ab2b189
Compare
Use the k8s_service_info for receiving the MLMD GRPC Service info instead of using the SDI, as it will stop being supported soon. This commit also ensures that mlmd runs with trust=True in the integration tests. Fixes #413
DnPlas
force-pushed
the
KF-5485-use-k8s-service-info-lib
branch
from
ab2b189
to
87e814c
Compare
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
labels
|
For the CI failures, please see this comment. |
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
|
The CI should now be green. |
ca-scribner
approved these changes
Apr 24, 2024
NohaIhab
pushed a commit
that referenced
this pull request
May 9, 2024
switch to jlumbroso/free-disk-space for freeing runner space (#428) The previous space freeing method (easimon/maximize-build-space) at some point circa 2024-01 stopped freeing as much space, likely due to changes in the runner (~29GB free after it freed space). Not sure why this happened, but jlumbroso/free-disk-space at time of this commit would get us up to ~45GB free on the runner without negative effects so we've switched to that. Support functionality to override default images for kfp-profile-controller (#416) * Support functionality to override default images for kfp-profile-controller ci: remove destructive mode from integration tests (#441) The charmcraft issues that forced us to use destructive mode are now fixed. build: install `jinja2` from binary (#443) This commit installs jinja2 (an install dependency of charmed-kubeflow-chisme) as a binary to avoid running into the build time issues described in canonical/bundle-kubeflow#883. Part of canonical/bundle-kubeflow#883 refactor: use k8s_service_info lib instead of SDI (#436) * refactor: use k8s_service_info lib instead of SDI Use the k8s_service_info for receiving the MLMD GRPC Service info instead of using the SDI, as it will stop being supported soon. This commit also ensures that mlmd runs with trust=True in the integration tests. Fixes #413 fix: Pin integration test dependencies in main (#434) * pin integration test dependencies Co-authored-by: Daniela Plascencia <[email protected]> feat: Integrate ROCK in metadata-writer charm (#439) chore: Bump o11y libs and remove obsolete juju topology (#446) Ref canonical/bundle-kubeflow#880 Ref canonical/bundle-kubeflow#849 ci: bump juju to 3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the k8s_service_info for receiving the MLMD GRPC Service info instead of using the SDI, as it will stop being supported soon.
This commit also ensures that mlmd runs with trust=True in the integration tests.
Fixes #413
NOTE for reviewers:
Also note that this component could be placed in chisme, BUT that requires us to put charm libraries in the package, which is under discussion by the team.
Depends on refactor: use k8s_service_info lib instead of SDI envoy-operator#87
Testing instructions
mlmdfromchannel latest/edgewithtrustTest upgrade path
kfp-metadata-writerfromchannel 2.0/stablewithtrustjuju refreshto the charm in this branch[grpc] Missing relation with a k8s service info provider. Please add the missing relation